Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match the number of outputs of backward with forward for AllGatherGrad #6625

Merged
merged 4 commits into from
Mar 25, 2021

Conversation

ArvinZhuang
Copy link
Contributor

@ArvinZhuang ArvinZhuang commented Mar 22, 2021

What does this PR do?

Fixes #6624

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch !

@Borda Borda added ready PRs ready to be merged bug Something isn't working labels Mar 23, 2021
@Borda
Copy link
Member

Borda commented Mar 23, 2021

@ArvinZhuang nice, can you also add a test to catch this issue later, I would say that the example from issue shall be fine :]

@ArvinZhuang
Copy link
Contributor Author

Hi @Borda, I have added a test that raises the error before the fix and passes after.

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix

@@ -95,3 +95,26 @@ def training_epoch_end(self, outputs) -> None:

trainer.fit(model)
assert model.training_epoch_end_called


@RunIf(min_gpus=2, skip_windows=True, special=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this won't run
we need to add add it to tests/special_tests.sh
special=True means this test gets skipped by default
and skip_windows would be redundant in that case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I noticed this, I actually commented out special=True when I test this. I put it here just because I was following the same settings of other tests in this script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuntimeError: function AllGatherGradBackward returned an incorrect number of gradients (expected 2, got 1)
7 participants